fix(search): wait for the source-created handler in the live setup test - #8227
Open
waleedlatif1 wants to merge 1 commit into
Open
waleedlatif1 wants to merge 1 commit into
waleedlatif1 wants to merge 1 commit into
Conversation
The live service-source test asserted updateSearchIntegration immediately after the create onSuccess act, but onCreated awaits the nuqs URL-state reset (which flushes asynchronously) before it starts the mutation, so the assertion raced the flush and failed most runs. Wait for it the same way the sibling setup test already does (vi.waitFor with a 1ms interval).
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
search-source-setup.test.tsx"selects a newly added live service source before navigating to it" fails most runs on staging (4/5 locally), which currently failsTest (shard 2)on every PRonCreatedawaits the nuqs URL-state reset, which flushes asynchronously, before it starts theupdateSearchIntegrationmutation, so asserting the mutation right after the createonSuccessact raced the flushvi.waitForwith a 1ms interval); no component changeType of Change
Testing
The test passes 10/10 locally (was failing 4/5); lint and
check:auditspass.Checklist